Indeed, why not accept both formats?
2007/2/22, Alexei Zakharov <[EMAIL PROTECTED]>:
IMHO the benifit of "dir+file name" approach is the fact that the test
name can be directly copied from exclude list to command prompt
without modifications. Theoretically it will be nice if we can support
both notations.
Thanks,
2007/2/21, Vladimir Ivanov <[EMAIL PROTECTED]>:
> Is it OK to chenge the notation of test case from "package+class name"
> to "dir+file name" ie from -Dtest.case=org.apache.harmony.<...> to
> -Dtest.case=org/apache/.../Test.java?
> Please, refer to Harmony-3187 for possible patches.
>
> thanks, Vladimir
>
>
> On 2/16/07, Vladimir Ivanov <[EMAIL PROTECTED]> wrote:
> > Issue 3187 was created to track it.
> > thanks, Vladimir
> >
> > On 2/16/07, Alexey Varlamov <[EMAIL PROTECTED]> wrote:
> > > 2007/2/16, Stepan Mishura <[EMAIL PROTECTED]>:
> > > > On 2/15/07, Alexey Varlamov wrote:
> > > > >
> > > > > This is also applicable to api vs injected tests, the worst case is
> > > > > security module which has all 4 types. I'd prefer this to be fixed.
> > > >
> > > >
> > > > Do we really need this option? Why not run the test in this way:
> > > > modules/lang-management> java -cp
> > > > bin/impl/:../../depends/jars/junit_3.8.2/junit.jar
junit.textui.TestRunner
> > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > >
> > > Well, it is a bit more complex for security - you need to place all
> > > needed resources to bootclasspath, but prior to this you need to find
> > > which resources are needed and there they are located :)
> > > Basically this is a matter of convenience - the same as whole
> > > "-Dtest.case" feature. So if this is cheap to fix, why not?
> > >
> > > >
> > > > -Stepan.
> > > >
> > > > E.g. via adding extra step to detect if the specified test really
> > > > > belongs to a suite and skipping the run otherwise. Yet not sure what
> > > > > to do if no such test ever ;)
> > > > >
> > > > > --
> > > > > Alexey
> > > > >
> > > > > 2007/2/15, Vladimir Ivanov <[EMAIL PROTECTED]>:
> > > > > > I forgot to add test run example:
> > > > > > >build.bat -Dbuild.module=lang-management
> > > > > > -
> > > > >
Dtest.case=org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > test
> > > > > > <snip>
> > > > > > run-tests-api:
> > > > > > [mkdir] Created dir:
C:\harmony.top\classlib\trunk\build\test_report
> > > > > > [junit] Running
> > > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> > > > > > [junit] Test
> > > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > FAILED
> > > > > >
> > > > > > touch-failures-file:
> > > > > >
> > > > > > touch-errors-file:
> > > > > >
> > > > > > run-tests-impl:
> > > > > > [junit] Running
> > > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.15
sec
> > > > > >
> > > > > > thanks, Vladimir
> > > > > >
> > > > > > On 2/15/07, Vladimir Ivanov <[EMAIL PROTECTED]> wrote:
> > > > > > > Hello everybody,
> > > > > > >
> > > > > > > when I ran separated TestCase'es I met a small issue: in the case
when
> > > > > > > we have 'api' and 'impl' tests, for example in the lang-management
> > > > > > > module, any test always failed in one run due to
'NoClassDefFound'.
> > > > > > >
> > > > > > > Is it OK to add some elements to classpath or should we change a
run a
> > > > > > > little bit or is it expected behavior?
--
Alexei Zakharov,
Intel ESSD
