Vladimir Ivanov wrote:
On 2/16/07, Gregory Shimansky <[EMAIL PROTECTED]> wrote:
On Friday 16 February 2007 15:49 Vladimir Ivanov wrote:
> The update for "test.property" file was included to smoke.patch (first).
> Please, be sure that it was patched and correct version is used.

The first patch also contains changes to exclude lists. Should they be applied
as well?

Sorry, seems my patch was not obvious :(
Actually, the updated patch includes only one file where conflict was
resolved so only this file should be updated in the first patch (all
other updates for files were not changed).
Thanks that you investigated this issue :)

Yes I guessed as much. I found just one problem with your patch. On IPF you redefine test.mode property in test.xml to run tests only in "int" mode because other modes aren't yet supported on this platform.

The problem is that redefinition of test/mode property doesn't make any effect in test.xml, so smoke tests are run in all 3 different modes, so they fail in jet and opt. This will have to be fixed although I am not sure how.


> On 2/16/07, Gregory Shimansky <[EMAIL PROTECTED]> wrote:
> > On Thursday 15 February 2007 13:43 Vladimir Ivanov wrote:
> > > Hello everyone,
> > > I would like to discuss modes to run DRLVM jvmti, smoke and kernel
> > > tests. Current state:
> > > - jvmti: interpreter + default
> > > - smoke: interpreter + default
> > > - kernel: interpreter + jet + opt
> > >
> > > I suggest to add command line switch (one for all tests) to set modes.
> > > In this case the default value will be:
> > > - jvmti: interpreter + jet + opt
> > > - smoke: interpreter + jet + opt
> > > - kernel: interpreter + jet + opt
> > >
> > > Command line interface will be:
> > > build.bat -Dtest.modes=jet,opt test
> > >
> > > Is it OK?
> > > Issue HARMONY-3182 was created to track it.
> >
> > I tried that patch and it didn't work as expected. It looks like there is > > no default mode because running jvmti and smoke tests gives the following
> > error:
> >
> > run-jvmti-tests:
> >
> > BUILD FAILED
> > C:\work\harmony\trunk\working_vm\build\make\build.xml:368: The following
> > error occurred while executing this line:
> > C:\work\harmony\trunk\working_vm\build\make\build_component.xml:72: The
> > following error occurred while executing this line:
> > C:
> > \work\harmony\trunk\working_vm\build\win_ia32_msvc_debug\semis\build\targ > >ets\jvmti.test.xml:152: The following error occurred while executing this
> > line:
> > C:
> > \work\harmony\trunk\working_vm\build\win_ia32_msvc_debug\semis\build\targ > >ets\jvmti.test.xml:154: The following error occurred while executing this
> > line:
> > C:
> > \work\harmony\trunk\working_vm\build\win_ia32_msvc_debug\semis\build\targ
> >ets\jvmti.test.xml:85: Property '${test.mode}.name' is not defined.
> >
> > or for smoke tests
> >
> > java_test_smoke_with_jit_or_interpreter:
> >
> > BUILD FAILED
> > /nfs/ims/proj/drl/mrt1/users/gregory/ipf-sles9/trunk/working_vm/build/mak > >e/build.xml:368: The following error occurred while executing this line: > > /nfs/ims/proj/drl/mrt1/users/gregory/ipf-sles9/trunk/working_vm/build/mak
> >e/build_component.xml:72: The following error occurred while executing
> > this line:
> > /nfs/ims/proj/drl/mrt1/users/gregory/ipf-sles9/trunk/working_vm/build/lnx > >_ipf_gcc_debug/semis/build/targets/smoke.test.xml:84: The following error
> > occurred while executing this line:
> > /nfs/ims/proj/drl/mrt1/users/gregory/ipf-sles9/trunk/working_vm/build/lnx > >_ipf_gcc_debug/semis/build/targets/smoke.test.xml:86: The following error
> > occurred while executing this line:
> > /nfs/ims/proj/drl/mrt1/users/gregory/ipf-sles9/trunk/working_vm/build/lnx
> >_ipf_gcc_debug/semis/build/targets/smoke.test.xml:110: Property
> > '${test.mode}.name' is not defined.
> >
> >
> > --
> > Gregory

--
Gregory




--
Gregory

Reply via email to