(I can't believe I'm defending them :)

*I* thought that some people were using them w/ their IDEs.

I'd be happy to leave them alone, but just as happy to see them go. If no one stands up and says they use them, we should probably remove.

geir

On Mar 1, 2007, at 2:45 AM, Mikhail Loenko wrote:

I'll remove them from jndi module

Thanks,
Mikhail

2007/3/1, Richard Liang <[EMAIL PROTECTED]>:
On 3/1/07, Nathan Beyer <[EMAIL PROTECTED]> wrote:
> I'd vote for deleting any extraneous AllTests files.

+1

>
> On 2/28/07, Alexei Zakharov <[EMAIL PROTECTED]> wrote:
> > > I think the AllTest makes sense only when some one want to run test
> > > suites partly. I had never used it but I'm not sure if there is
> > > somebody who perfer that way.
> >
> > Well, seems AllTest is a history now. It doesn't make use of exclude > > lists and etc. Moreover, some modules does not support it - i.e. does
> > not have AllTest.. IIRC we have agreed that storing grouping
> > information in java source is (generally) not a very good idea.
> >
> > Thanks,
> >
> > 2007/2/28, Tony Wu <[EMAIL PROTECTED]>:
> > > On 2/28/07, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> > > > Thanks, Stepan
> > > >
> > > > Seems like the key is "cleaned my working copy" here. Because I saw no
> > > > problems when tested my commit.
> > > >
> > > yes, there might be a TestBasicControl.class in classpath if did not clean.
> > >
> > > > BTW, do these "AllTest" make sense? Does anybody use them?
> > > > We do'nt have all the tests included into "AllTest", so it might make
> > > > sense to get rid of them
> > > >
> > >
> > > I think the AllTest makes sense only when some one want to run test
> > > suites partly. I had never used it but I'm not sure if there is
> > > somebody who perfer that way.
> > >
> > > > Thanks,
> > > > Mikhail
> > > >
> > > > 2007/2/28, Stepan Mishura <[EMAIL PROTECTED]>:
> > > > > On 2/28/07, Tony Wu <[EMAIL PROTECTED]> wrote:
> > > > > >
> > > > > > I cleaned my working copy and ran "ant - Dbuild.module=jndi test",
> > > > > > then I got following compile error.
> > > > >
> > > > >
> > > > > Fixed at r512588.
> > > > >
> > > > > -Stepan.
> > > > >
> > > > > [javac] 1. ERROR in
> > > > > >
> > > > > > /home/clear/trunk/modules/jndi/src/test/java/org/ apache/harmony/jndi/tests/javax/naming/ldap/AllTestLdap.java
> > > > > >    [javac]  (at line 49)
> > > > > > [javac] suite.addTest(new TestSuite (TestBasicControl.class)); > > > > > > [javac] ^^^^^^^^^^^^^^^^
> > > > > >    [javac] TestBasicControl cannot be resolved to a type
> > > > > >    [javac] ----------
> > > > > >    [javac] 1 problem (1 error)
> > > > > >
> > > > > > I did not find the TestBasicControl.java in jndi src.
> > > > > >
> >
> > --
> > Alexei Zakharov,
> > Intel ESSD
> >
>


--
Richard Liang
China Development Lab, IBM


Reply via email to