Thanks a lot for your ideas.
Another patch is attached to JIRA.
As it was suggested there is a enum of 3 values instead of additional
method.
gt.
George Timoshenko wrote:
Some time ago 'vm_helper_is_gc_interruptible' method appeared in the
interface. It is used in JIT to identify if a helper call can be
interrupted by gc for enumeration. And if a helper is interruptible in
some circumstances and is not interruptible in other cases the methods
returns TRUE, as GC-support in JIT must be ready to provide data for gc.
(for example there are monitor enter/exit helpers with such behavior)
Another JIT functionality (BBPolling) needs to know if a helper call can
be interrupted for sure. So that method (vm_helper_is_gc_interruptible)
can not be used as is.
My suggestion is to extend VM-JIT interface with one more method
'vm_helper_is_interruptible' that returns true if a helper can be
interrupted for sure.
Possible implementation is attached to HARMONY-2057
(https://issues.apache.org/jira/browse/HARMONY-2057)
What do you think about it?
