Hi, Mark,

I see not trick for drlvm if it follows the changes you are proposing
related getZipCachePool.

In fact drlvm has just a few code in VMI implementation, in paticular
HyZipCachePool is not used in drlvm (it is referenced in VMI implementation
only). Also DRLVM Class Support component does not use ZipCachePool stuff
(although it may worth start using it).

An only thing here I see: as soon as your patch is ready (for HARMONY-3563)
let's check the drlvm is buildable with a new interface - some changes may
require to be done in: working_vm/vm/vmi/src/vmi.cpp - so I or Gregory
should handle this.

Thanks
Vladimir Beliaev



2007/5/16, Mark Hindess <[EMAIL PROTECTED]>:


Resurrecting this old thread...

I'd like to move forward with this issue.  Since it is a VM interface
change, it is a little tricky to move forward since we'd need support
in the VMs but I think that it is important that we make progress
in cleaning up the VM interface to remove exposure of internal data
structures.  (There are other instances of this already, hy.no.thr, that
I'll raise in a separate thread[no pun intended].)

Ron has helpfully attached a patch to the JIRA:

https://issues.apache.org/jira/browse/HARMONY-3563

that makes use of the new api an option, so I'd be willing to commit it
now.  However, I'd really like to hear from others (particularly those
working on drlvm) before moving forward with this.

Regards,
Mark.

On 4 April 2007 at 11:08, "Alexey Petrenko" <[EMAIL PROTECTED]>
wrote:
> +1 for such a changes.
>
> SY, Alexey
>
> 2007/4/4, Ronald Servant <[EMAIL PROTECTED]>:
> > The structure of the HyZipCachePool provided in the VMI through
> > getZipCachePool() exposes internal VM data structures.
> >
> > We should replace getZipCachePool() with a set of functions that
> > implement a Zip API.  Isolating internal data structures.
> >
> > I have opened H-3563 and attached a patch to address this issue.
> >
> > Let me know your thoughts.
> >
> > Ron.
> > --
> > J9 VM Development
> > IBM Ottawa Software Lab
> >
>





--
Vladimir Beliaev
Intel Middleware Products Division

Reply via email to