Alexey Varlamov wrote:
2007/5/23, Gregory Shimansky <[EMAIL PROTECTED]>:
Olivier Thomann wrote:
> news <[EMAIL PROTECTED]> wrote on 2007-05-23 11:37:09:
>> Olivier Thomann wrote:
>> Ah I was mistaken when I wrote that org.apache.harmony.boot.class.path
>> is the right property to be used. This property is created by classlib
>> initialization code and actually specifies all JAR files which classlib
>> has (kernel classes are VM specific). DRLVM adds kernel.jar to the
>> property and creates vm.boot.class.path and sun.boot.class.path, the
>> latter for compatibility with Sun.
> I could search for "sun.boot.class.path" first and if not present, use
> "vm.boot.class.path".

Just small correction, if sun.boot.class.path is not found, search for
org.apache.harmony.boot.class.path. It is the only property that IBM VME
provides, and it has correct value for it. On DRLVM sun.boot.class.path
and vm.boot.class.path are equal and contain kernel.jar, while
org.apache.harmony.boot.class.path doesn't contain it (this should not
be a problem if you search for sun.boot.class.path first).

Let's get rid of that duplicate "vm.boot.class.path" -
org.apache.harmony.boot.class.path + sun.boot.class.path is more than
enough.
And to avoid confusion in future, re-initialize the first with the
full bootclasspath in DRLVM as well.

Property vm.boot.class.path is used in kernel classes of VM and I think it is better to have a property with name independent from sun. It was actually added by me long time ago when there was no JDWP agent in Harmony and I tried to use JDWP agent library from BEA to debug JVMTI implementation. That agent library didn't work without sun.boot.class.path. It good to define this property for compatibility, but not actually use it I think.

If we correctly set org.apache.harmony.boot.class.path to include kernel JAR files from VM we can get rid of vm.boot.class.path and use org.apache.harmony.boot.class.path in kernel classes implementation.


> Then this would not require any change in the Harmony properties. So as
> long as these
> properties are properly initialized, it should work fine.
>
> I'll preserve the current heuristic in case none of the properties is set.

Sure. I wonder what IBM's J9 provides. I saw some code in eclipse which
reads com.ibm.oti.system.class.path property. But maybe it provides
sun.boot.class.path for compatibility too...

> Does this sound good enough?

Yes!

[1]
http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.jdt.launching/support/org/eclipse/jdt/internal/launching/support/LibraryDetector.java?revision=1.9&view=markup

--
Gregory





--
Gregory

Reply via email to