Stepan Mishura wrote: > On 6/20/07, Tony Wu <[EMAIL PROTECTED]> wrote: <snip> >> I'm afraid that if we throw exception while RI does not in case above, >> it may break some application which depends on RI's behavior. IMHO, >> we'd better follow the behavior of RI in jndi. Agree? >> > > Yes, we may beak application that relies on encodings that are invalid > according to BER spec ...IMHO it is not good for the application. > > Well, as far as I see RI just ignores a value of the length byte. Of > cause we may do the same to extend BerInputStream and remove this > check. This approach looks better for me then copying all > encoders/decoders to 'jndi' module. But personally, I'd follow BER > spec. and reject invalid encodings.
I agree that we should reject invalid encodings, unless there is a compelling application that requires us to extend BerInputStream this way. It should be logged as a non-bug difference too. Regards, Tim
