On 7/31/07, Tim Ellison <[EMAIL PROTECTED]> wrote: > > [EMAIL PROTECTED] wrote: > > Modified: > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java > > URL: > http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java?view=diff&rev=561285&r1=561284&r2=561285 > > > ============================================================================== > > --- > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java > (original) > > +++ > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java > Tue Jul 31 02:39:44 2007 > > @@ -39,7 +39,7 @@ > > * > > * @return true if the stack is empty, false otherwise > > */ > > - public boolean empty() { > > + public synchronized boolean empty() { > > return elementCount == 0; > > } > > Why make this synchronized?
The synchronize on empty() method seems unnecessary. I have removed it at r561301. Is it all right, Spark? Regards, > Tim > -- Leo Li China Software Development Lab, IBM
