Hello Stepan, As per our dicsussion I've created a JIRA issue with a distinctive name [1]. Could one please close HARMONY-4114 [2]?
Thanks. [1] http://issues.apache.org/jira/browse/HARMONY-4992 [2] http://issues.apache.org/jira/browse/HARMONY-4114 On 10/16/07, Stepan Mishura <[EMAIL PROTECTED]> wrote: > On 10/15/07, Alexei Fedotov <[EMAIL PROTECTED]> wrote: > > Stepan, > > Thank you for your attention to this issue. > > > > Let me define a term we are using first. "VM specific behavior" > > actually is an abstract behavior which is VM specific, and not a > > behavior, which is specific for DRLVM. To make tests flexible for any > > behavior, I've made them looking like performance tests. For reporting > > performance-like metrics p-unit was a viable alternative, see the wiki > > page [1] for comparison. So p-unit integration is not something > > separate from the stress test suite: it suites actual needs. > > > > Alexei, > > I'd like to have clear distinction between HARMONY-4114, (according to > the its description - "VM intermittently throws *UNEXPECTED* > OutOfMemoryError on the test which defines heap fragmentation") and > p-unit integration. > > IMHO we shouldn't mix patches for different tasks/issues in one JIRA. > > > From technical point of view the patch may be split into several > > patches. There is even more interesting alternative to get p-unit as > > an external dependency for our repository. > > > > Yes, please separate them if that possible - it will make easier > understanding changes. Also please provide some relevant comments for > updates. Otherwise, it is hard to understand from comments below that > the patch integrates p-unit: > > "28/Sep/07 11:08 AM: > should be applied: > 5. harness_test_handler.patch (30 kb) > 7. stress.patch (1.12 Mb) > > should be executed: > 1. add_remove.sh (8 kb) " > > Thanks, > Stepan. > > > Thanks. > > > > [1] http://wiki.apache.org/harmony/Harmony_Test_Harness_Comparison > > > > On 10/15/07, Stepan Mishura <[EMAIL PROTECTED]> wrote: > > > Alexei, > > > > > > Why you attached patches for integrating p-unit to HARMONY-4114 that > > > primary aimed to fix specific VM behaviour? IMHO p-unit integration a > > > different story and needs a separate JIRA to keep things clear. Agree? > > > > > > Thanks, > > > Stepan. > > > > <SNIP> > -- With best regards, Alexei, ESSD, Intel
