I agree that we need to mark the unimplemented methods with NotImplementedException, it's important that people understand what is not there.
Regards, Tim Dmitry Irlyanov wrote: > I've do justify the emty methods in swing. > H3111-plaf.patch<https://issues.apache.org/jira/secure/attachment/12350137/H3111-plaf.patch> > H3111-AccessibleJToggleButton.patch<https://issues.apache.org/jira/secure/attachment/12351230/H3111-AccessibleJToggleButton.patch> > already verified. It simplifies the work. > > Also I should note that awt module also demands attension because the missed > implementation reveals after the justification has been performed (perhaps, > justification criteria has been too strong) see > https://issues.apache.org/jira/browse/HARMONY-4500 for example. > > 2007/11/30, Alexey Petrenko <[EMAIL PROTECTED]>: >> Yes, thanks for the reminder. >> That patches were created without any justification of the fact that >> methods are not implemented. >> >> So we probably need to spend some time on this. >> >> SY, Alexey >> >> 2007/11/30, Dmitry Irlyanov <[EMAIL PROTECTED]>: >>> Alexey, >>> >>> AFAIK https://issues.apache.org/jira/browse/HARMONY-3111 has been closed >> as >>> wontfix, so we really have unimplemented methods in swing. >>> >>> 2007/11/30, Alexey Petrenko <[EMAIL PROTECTED]>: >>>> Guys, >>>> >>>> Andrey Pavlenko and I have discovered yesterday that our imageio >>>> implementation is not complete in spite of marked as 100% complete by >>>> japitool. >>>> >>>> Andrey is preparing a patch to mark all the unimplemented methods but >>>> we need to check other modules for such a things... >>>> >>>> Any volunteers? :) >>>> >>>> SY, Alexey >>>> >>>> P.S. We've checked awt and swing modules some time ago and I believe >>>> that all the unimplemented methods are marked there. >>>> >>> >>> >>> -- >>> _______________ >>> With Best Regards, >>> Irlyanov Dmitry >>> > > >
