This issue has slipped through the cracks recently, so Ive raised
HARMONY-5371 for it so it isn't forgotten.
Any VM volunteers who can make this change?
Regards,
Oliver
Alexey Petrenko wrote:
Yes, it seems so...
Volunteers in VM? :)
SY, Alexey
2007/11/13, Oliver Deakin <[EMAIL PROTECTED]>:
Sorry about the break - I have reverted the commit to fix it teporarily,
but I think we should move this over to the DRLVM build since it is no
longer used by classlib.
Regards,
Oliver
Alexey Petrenko wrote:
2007/11/13, Gregory Shimansky <[EMAIL PROTECTED]>:
Alexey Petrenko wrote:
Hmmm....
I can not build DRLVM now with the following error message:
[cc] Class_File_Loader.cpp
[cc] C:\Users\cap\harmony\working_vm\vm\vmcore\src\class_support\Class_Fi
le_Loader.cpp(38) : fatal error C1083: Cannot open include file: 'unicode/uchar.
h': No such file or directory
And looks like reverting to revision 594205 fixes the issue...
So looks like we need update for VM.
Hmm I didn't make a clean checkout of the code for a long time, so maybe
some dependencies are downloaded already and this allows me to build the
VM without problems. But [1] points to some revision in incubator, are
you sure that the revision is correct?
[1] http://svn.apache.org/viewvc?view=rev&revision=594205
I've just stepped one revision back from Oliver's 594206 :)
SY, Alexey
2007/11/12, Oliver Deakin <[EMAIL PROTECTED]>:
No objections, so patch applied and icu4c header zips removed at repo
revision r594206.
Regards,
Oliver
Oliver Deakin wrote:
Hi all,
I noticed that the icu4c header files are still being unpacked into
deploy/include by the classlib build-native.xml "overlay-oss" target.
This is no longer necessary for classlib, so I was going to remove
these lines and also the archived header files in depends/oss [1].
Before I do this, I just wanted to check that they are not required by
DRLVM. Does anyone object to their removal?
Regards,
Oliver
[1]
Index: build-native.xml
===================================================================
--- build-native.xml (revision 593110)
+++ build-native.xml (working copy)
@@ -160,26 +160,12 @@
<!-- =================================
target: overlay-oss
================================= -->
- <condition property="iculib.zip"
- value="${depends.oss}/icu4c-3.4-harmony-windows.x86_64.zip"
- else="${depends.oss}/icu4c-3.4-harmony.zip">
- <and>
- <isset property="is.windows"/>
- <isset property="is.x86_64"/>
- </and>
- </condition>
-
<target name="overlay-oss">
<ant dir="modules/luni" antfile="build.xml"
target="overlay-oss" />
<ant dir="modules/archive" antfile="build.xml"
target="overlay-oss" /> - - <mkdir
dir="${hy.hdk}/include/icu4c/unicode" />
- <unzip src="${iculib.zip}"
dest="${hy.hdk}/include/icu4c/unicode" />
- <chmod dir="${hy.hdk}/include/icu4c/unicode" perm="ugo+r" />
- <copy file="${hy.hdk}/include/icu4c/unicode/icuuc.lib"
todir="${native.lib.target}" overwrite="yes"/>
</target>
<!-- =================================
@@ -245,7 +231,6 @@
target="clean-overlay-oss" />
<ant dir="modules/archive" antfile="build.xml"
target="clean-overlay-oss" />
- <delete dir="${hy.hdk}/include/icu4c" quiet="true" />
</target>
</project>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
--
Gregory
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
