On 2/11/08, Stepan Mishura <[EMAIL PROTECTED]> wrote: > Hi Andrey, >
Ops, sorry Alexey (I've just realized that I used wrong first name) -Stepan. > It is very good when a bug is fixed. But IMHO without a regression > test the fix is not complete - there is a chance to broke accidentally > fixed functionality again (i.e. introduce a regression). And a > regression test helps to catch this early. > > I think this a good practice to accompany each fix with the regression > test (of cause if it is possible). The JIRA contains problem > reproducer. Is it possible to convert is to the unit test? > > Thanks, > Stepan. > > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Monday, February 11, 2008 5:14 PM > To: [EMAIL PROTECTED] > Subject: svn commit: r620461 - > /harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java > > Author: apetrenko > Date: Mon Feb 11 03:14:08 2008 > New Revision: 620461 > > URL: http://svn.apache.org/viewvc?rev=620461&view=rev > Log: > Patch for HARMONY-5473 "[classlib][archive] Manifest file with empty > line proves IOException" > > Modified: > > harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java > > Modified: > harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java > URL: > http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java?rev=620461&r1=620460&r2=620461&view=diff > ============================================================================== > --- > harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java > (original) > > <SNIP> >
