Tim Ellison said the following on 12.02.2008 22:32:
Gregory,

Is this appropriate during feature freeze? Looks like significant new functionality.

Oh. I didn't realize the _feature_ freeze started up already! I only remembered the date 15th of February from your email. I must have not read it carefully enough. The good thing is that this is not a _feature_ per say since crash handler had problems printing good stack traces on x86_64, so it could be called a bug to some extent. On the other hand, if I was aware about the freeze, I'd hold on committing such big change.

Do you guarantee all this code going to work perfectly ?! <g>

Well, the code in question is targeted to work only in case of a crash which shouldn't happen in the first place. So I hope it is not critical for general stability. If any regression is noticed, I'll revert this commit.

[EMAIL PROTECTED] wrote:
Author: gshimansky
Date: Tue Feb 12 09:30:49 2008
New Revision: 620872

URL: http://svn.apache.org/viewvc?rev=620872&view=rev
Log:
Applied patch from HARMONY-5490
[drlvm][signals] New heuristics for crash handler


Added:
harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/linux/native_stack_os.cpp (with props) harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/win/native_stack_os.cpp (with props)
Modified:
harmony/enhanced/drlvm/trunk/vm/port/src/encoder/ia32_em64t/dec_base.cpp harmony/enhanced/drlvm/trunk/vm/port/src/encoder/ia32_em64t/enc_tabl.cpp harmony/enhanced/drlvm/trunk/vm/port/src/lil/ia32/pim/stack_iterator_ia32.cpp
    harmony/enhanced/drlvm/trunk/vm/vmcore/include/native_stack.h
    harmony/enhanced/drlvm/trunk/vm/vmcore/include/ncai_internal.h
    harmony/enhanced/drlvm/trunk/vm/vmcore/include/vm_core_types.h
    harmony/enhanced/drlvm/trunk/vm/vmcore/src/ncai/ncai_stack.cpp
    harmony/enhanced/drlvm/trunk/vm/vmcore/src/stack/stack_dump.cpp
harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/em64t/base/native_stack_em64t.cpp harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/ia32/base/native_stack_ia32.cpp harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/ipf/base/native_stack_ipf.cpp
    harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/native_stack.cpp

Reply via email to