Thanks, Alexei! +1 for committing the patch. Mikhail
On 2/19/08, Alexei Zakharov <[EMAIL PROTECTED]> wrote: > > Sure guys, the patch is now attached to HARMONY-5498. It only affects > the scenario code we are not going to release anyway. > > Thanks, > Alexei > > 2008/2/18, Mikhail Markov <[EMAIL PROTECTED]>: > > As the modifications are in the scenario and not in Harmony code (thus > not > > affecting anything else) i'm +1 for committing it, but Alexei is right - > it > > would be nice to see the patch itself :-). > > > > Thanks, > > Mikhail > > > > > > On 2/18/08, Alexey Petrenko <[EMAIL PROTECTED]> wrote: > > > > > > I can not find the patch you are going to commit in the issue... > > > > > > Thanks in advance. > > > > > > SY, Alexey > > > > > > 2008/2/18, Alexei Zakharov <[EMAIL PROTECTED]>: > > > > All, > > > > > > > > As it was agreed I'm going to commit the changes to the Struts > > > > scenario to let it follow the current Harmony behavior - we may use > it > > > > for the snapshot testing after fixing it. See HARMONY-5498 for > > > > details. I'm waiting for other committer's vote. > > > > > > > > Thanks, > > > > Alexei > > > > > > > > 2008/2/14, Alexei Zakharov <[EMAIL PROTECTED]>: > > > > > > > The senario test is writtern by ourselves. My question is, > will > > > this > > > > > > > difference block the struts or not? > > > > > > > > > > I can't say that Struts is *blocked* by this difference. It just > uses > > > > > it in one of its standard examples. And our struts scenario checks > > > > > that example. In respect that the example itself is not a > production > > > > > application and RI's behavior looks strange indeed I agree we may > mark > > > > > it as a non-bug difference and fix Struts scenario to follow the > > > > > current Harmony behavior. > > > > > > > > > > Alexei > > > > > > > > > > 2008/2/13, Tim Ellison <[EMAIL PROTECTED]>: > > > > > > Tony Wu wrote: > > > > > > > Tim, Alexei > > > > > > > Seems it is locale dependent. I tried several locales, there > is a > > > > > > > empty string in the output. I can not tell why RI behaves > like > > > this. > > > > > > > > > > > > > > The senario test is writtern by ourselves. My question is, > will > > > this > > > > > > > difference block the struts or not? If it blocks struts we > have > > > to > > > > > > > work around even if the fix does harm to performance. If not, > > > let's > > > > > > > keep it as non-bug difference and find out the reason. > > > > > > > > > > > > My inclination is to leave the current behavior as-is, a > non-bug > > > > > > difference until we get a compelling reason to duplicate this > > > 'bug'. > > > > > > > > > > > > Regards, > > > > > > > > > > > > Tim > > > > > > > > > > > > > > >
