Ok, if nobody objects we will keep the patch. However, Alexei is welcome with the fix :)
SY, Alexey 2008/2/21, Andrey Pavlenko <[EMAIL PROTECTED]>: > It looks like the applied patch is not quite correct because it introduced a > bug violating the spec. But, from the other side, the bug is not very > critical and can be fixed later. IMO it's ok to fix this issue after M5. > > On Thu, Feb 21, 2008 at 12:26 PM, Alexey Petrenko < > > [EMAIL PROTECTED]> wrote: > > > 2008/2/21, Stepan Mishura <[EMAIL PROTECTED]>: > > > On 2/20/08, Alexey Petrenko <[EMAIL PROTECTED]> wrote: > > > > Guys, > > > > > > > > I'm going to revert r620461 because it looks like it causes a > > > > functional suite failure... > > > > Any objections? > > > > > > > > > As JIRA description says: "cannot start some of my apps, because their > > > jar-files contain manifests with empty lines". > > > > > > So with the patch applied we have 'some apps' running and 1 failing > > > func test. With reverted patch we will have 'some apps' failing and 1 > > > passing test. I thought that apps have higher priority so I'm not sure > > > that the patch should be reverted. > > > > > > Is there any chance to fix the issue entirely? > > This would be the best solution. But unfortunately I have no time at > > the moment and no other volunteers to fix it. > > > > So we got two options: to revert or not revert... > > > > Other opinions? Volunteers? > > > > SY, Alexey > > >
