Thanks, i will shout with code. :-)
2008/4/10, Tim Ellison <[EMAIL PROTECTED]>:
> Thanks. Just shout if you want some help.
>
> Regards,
> Tim
>
>
> Sean Qiu wrote:
> > I am so sorry about it.
> >
> > I think it is because i pay less attention to the test.
> > I will pay more attention to it from now on.
> >
> > I will supply the patch ASAP.
> > Sorry again. :(
> >
> > 2008/4/10, Tony Wu <[EMAIL PROTECTED]>:
> >
> > > Yes, agree. Thanks Tim.
> > >
> > > Sean,
> > >
> > > would you please submit another patch for HARMONY-5699 with tidy-up...
> > >
> > > On 4/9/08, Tim Ellison <[EMAIL PROTECTED]> wrote:
> > >
> > > > Tony,
> > > >
> > > > I think these tests need a bit of tidy-up,
> > > >
> > > > - lots of assertEquals true|false|null where it would be more natural
> and
> > > > readable to use assertTrue, assertNull etc.
> > > >
> > > > Just write:
> > > > assertEquals("Should equal to be empty.", true, map.isEmpty());
> > > > as
> > > > assertTrue(map.isEmpty());
> > > >
> > > > - contains unhelpful printing to stdout "System.out.println(map);"
> > > >
> > > > Regards,
> > > > Tim
> > > >
> > >
> >
>
>
--
Best Regards
Sean, Xiao Xia Qiu
China Software Development Lab, IBM
