Done, please check out updated patch in JIRA. Thanks, Aleksey.
On Fri, Apr 18, 2008 at 4:07 AM, Xiao-Feng Li (JIRA) <[EMAIL PROTECTED]> wrote: > > [ > https://issues.apache.org/jira/browse/HARMONY-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590249#action_12590249 > ] > > Xiao-Feng Li commented on HARMONY-5759: > --------------------------------------- > > > Aleksey, the patch looks good. > > Could you change "BLOCK_BASE_ALIGNMENT" to be > "GC_BLOCK_BODY_ALIGNMENT"? BASE actually refers to the start of a > block. BODY is the start of the allocatable area. (And same to > BLOCK_BASE_ALIGN_MASK). Thanks. > > I will commit after you make the modification. > > Thanks, > xiaofeng > > On Fri, Apr 18, 2008 at 1:01 AM, Aleksey Shipilev (JIRA) > > > > > > -- > http://xiao-feng.blogspot.com > > > > [drlvm][gc][performance] Alignment of GC blocks could improve the > performance of FP benchmarks > > > ---------------------------------------------------------------------------------------------- > > > > Key: HARMONY-5759 > > URL: https://issues.apache.org/jira/browse/HARMONY-5759 > > Project: Harmony > > Issue Type: Improvement > > Reporter: Aleksey Shipilev > > Attachments: vm-gc-blocksize-rc1.patch > > > > > > This issue defines the block alignment to be separated from object > alignment. This would allow to leave the object alignment at 4 and not to > waste precious memory, but on other hand will open the way for alignment of > GC blocks to 8 thus increasing the chances that data requiring 8/16 alignment > will layout in memory properly. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
