Hi Alexei, Sorry for the late reply. Our semester is approaching the mid terms and I've had to complete a few assignments. Started working on some patches today again.
I took your advice and started trying out things and made some good progress. I have gotten the hang of how to approach the whole project now. I thought the DebugGraphics class wasn't supposed to implement that method. That's why I took that measure to correct the error. (by checking for type). I ran the whole swing test suite and got 137 errors. (Fixed up 2 today and just submitted the patch). I ran it through Eclipse. Regards, Tharindu On Tue, Jul 1, 2008 at 8:05 PM, Alexei Fedotov <[EMAIL PROTECTED]> wrote: > Hello Tharindu, > > I'm sorry for being offine for a while. It seems you have made a good > progress. I will try to catch up with you in few days. Mark, thank you > for taking care of the fixes. > > I have a question concerning a patch for HARMONY-5874. Why are we > adding a kludge to javax/swing/JComponent instead of adding an empty > method to DebugGraphics class? > > Thanks! > > BTW, today I was running swing unit tests in my new environment and > saw 179 errors. How this relates to your test status? > $ ant test -Dbuild.module=swing > -Dtest.jre.home=c:/work/1a/hdk/target/hdk/jdk/jre/ > > On Tue, Jun 17, 2008 at 3:42 PM, Mackie Mathew <[EMAIL PROTECTED]> > wrote: > > The patches below addresses issues that were present in JComponent that > > failed tests of JComponentTest. > > > > https://issues.apache.org/jira/browse/HARMONY-5875 > > https://issues.apache.org/jira/browse/HARMONY-5874 > > > > Regards, > > > > Tharindu > > > > > > -- > With best regards, > Alexei >
