Re: svn commit: r695112 - in /harmony/enhanced/classlib/trunk/modules: beans/src/main/java/java/beans/ beans/src/main/java/java/beans/beancontext/ beans/src/test/java/org/apache/harmony/beans/tests/java/beans/ beans/src/test/java/org/apache/harmony/b

Mon, 15 Sep 2008 23:10:01 -0700

Thanks Chunrong and Sean, I haven't noticed javax.naming.directory.Attribute is a interface. 

Sean Qiu wrote:

Sorry, according to the spec,  serialVersionUID of
javax.naming.directory.Attribute should be "public static final long".
Resolved at  r695258.

2008/9/14 chunrong lai <[EMAIL PROTECTED]>:

 As  reported by the integrity testing,
 the commit breaks the HDK build with error message like below,
 it seems that the modifiers "private static final ..." introduced by this
patch are caught.

    [java] -compile:
    [java]     [mkdir] Created dir:
/home/laichunrong/harmony.regularcc/infra/build/checkouts/hdk/working_classlib/build/classes
    [java]  [hy.javac] Compiling 3620 source files to
/home/laichunrong/harmony.regularcc/infra/build/checkouts/hdk/working_classlib/build/classes
    [java]  [hy.javac] ----------
    [java]  [hy.javac] 1. ERROR in
/home/laichunrong/harmony.regularcc/infra/build/checkouts/hdk/working_classlib/modules/jndi/src/main/java/javax/naming/directory/Attribute.java
    [java]  [hy.javac]  (at line 81)
    [java]  [hy.javac] private static final long serialVersionUID =
0x78d7ee3675a55244L;
    [java]  [hy.javac]                           ^^^^^^^^^^^^^^^^
    [java]  [hy.javac] Illegal modifier for the interface field
Attribute.serialVersionUID; only public, static & final are permitted
    [java]  [hy.javac] ----------
    [java]  [hy.javac] 1 problem (1 error)
    [java]
    [java] BUILD FAILED



Modified:
harmony/enhanced/classlib/trunk/modules/jndi/src/main/java/javax/naming/directory/Attribute.java
URL:
http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/jndi/src/main/java/javax/naming/directory/Attribute.java?rev=695112&r1=695111&r2=695112&view=diff
==============================================================================
---
harmony/enhanced/classlib/trunk/modules/jndi/src/main/java/javax/naming/directory/Attribute.java
(original)
+++
harmony/enhanced/classlib/trunk/modules/jndi/src/main/java/javax/naming/directory/Attribute.java
Sat Sep 13 22:10:28 2008
@@ -78,7 +78,7 @@
    * This constant is used during deserialization to check the version
which
    * created the serialized object.
    */
-    static final long serialVersionUID = 0x78d7ee3675a55244L;
+    private static final long serialVersionUID = 0x78d7ee3675a55244L;

On Sun, Sep 14, 2008 at 1:10 PM, <[EMAIL PROTECTED]> wrote:


Author: qiuxx
Date: Sat Sep 13 22:10:28 2008
New Revision: 695112

URL: http://svn.apache.org/viewvc?rev=695112&view=rev
Log:
Apply for HARMONY-5982,([classlib] - serialVersionUID should be declared
private.)

Reply via email to