Tony Wu wrote:
I think so. since we already have the OSMemoryWin32 and
OSMemoryLinux32.c for the different implementation.
Thanks your reminder, I just noticed that :)
So in my understanding, the platform dependent code should be placed in
OSMemoryWin32/OSMemoryLinux32, others should be moved to "shared"
directory, right?
I have filed a JIRA [1] for this, and will create patch soon.
[1] https://issues.apache.org/jira/browse/HARMONY-6030
On Mon, Dec 1, 2008 at 3:11 PM, Regis <[EMAIL PROTECTED]> wrote:
Hi,
I just found OSMemory.h has almost the same content in windows and unix, the
only differences are order of function definitions and comments. So I think
if they should be merged and moved to shared directory?
And I go through OSMemory.c quickly, found the most implementation are also
similar, looks like:
windows:
hymem_free_memory ((void *) address);
unix:
hymem_free_memory ((void *) ((IDATA) address));
I'm not clear why we need one more cast here, or is it possible to merge
this two implementations to one? If so, I'm volunteer to do this :)
