Just an observation...

[EMAIL PROTECTED] wrote:
> @@ -311,7 +312,7 @@
>              buf.append('=');
>              if (value.escapedString == value.getHexString()) {
>                  //FIXME all chars in upper case
> -                buf.append(value.getHexString().toUpperCase());
> +                buf.append(Util.toUpperCase(value.getHexString()));
>              } else if (value.escapedString.length() != 
> value.rawString.length()) {
>                  // was escaped
>                  value.appendQEString(buf);

Seems odd in the first place to have converted the value to a hex string
with the wrong capitalization, then create a new string with the right
capitalization.

What would break if we changed the impl of getHexString() to return caps
rather than optimize the toUpperCase()?

Regards,
Tim

Reply via email to