Hi, I had some spare time and made the benchmark [1] for this issue (never do the performance optimizations without the benchmarks covering your case :)).
Presumably the good patch for the issue should increase the score on this benchmark. If my understanding is good, the boost should be observed on J9 with Kevin's version of the patch. The boost on DRLVM should be observed with the final patch. Thanks, Aleksey. On Harmony-M7 at P-D 2.8 Ghz / PC2-5300 / Gentoo Linux x86: $ harmony-M7/bin/ava -Xms1024M -Xmx1024M -server -jar StringBench.jar (String)base + (int)add: ------------------------------------------- base length (vars with rows): 0..2..10 add length (vars with cols): 0..2..10 loop duration = 100 msecs target variance = 0.05 ops/msec, the more the better: 4369, 2842, 1976, 1563, 1226, 4462, 2829, 1966, 1555, 1225, 4430, 2836, 1956, 1563, 1223, 4394, 2831, 1956, 1558, 1217, 4357, 2821, 1954, 1551, 1217, Thanks, Aleksey. [1] https://issues.apache.org/jira/secure/attachment/12397340/StringBench.jar On Wed, Jan 7, 2009 at 6:18 PM, Tim Ellison <[email protected]> wrote: > Aleksey Shipilev wrote: >> Ok, we can implement the in-place Integer.toString() and specialize >> the radix-10 conversion in Integer. Then Classlib performance guys >> might use the inplace conversion to optimize StringBuilder performance >> or even catch the concatenation like J9 does. >> >> My idea is to share whatever optimization between all VMs that use the >> Classlib. > > indeed! > >
