It is against the specification, and I'd rather remove the call than
comment it out. After all we have SVN to track such changes and log
reasons for them.
WBR,
Pavel.
On Mon, Jan 5, 2009 at 3:50 PM, Xiao-Feng Li <[email protected]> wrote:
> Chunrong, Is it better to put a comment on-site explaining why the
> class is not initialized?
>
> Thanks.
> xiaofeng
>
> On Mon, Jan 5, 2009 at 6:14 PM, <[email protected]> wrote:
>> Author: chunrong
>> Date: Mon Jan 5 02:14:19 2009
>> New Revision: 731515
>>
>> URL: http://svn.apache.org/viewvc?rev=731515&view=rev
>> Log:
>> Remove Class Initialization in array allocation, to pass test cases in
>> HARMONY-6020
>>
>> Modified:
>> harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp
>>
>> Modified:
>> harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp
>> URL:
>> http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp?rev=731515&r1=731514&r2=731515&view=diff
>> ==============================================================================
>> --- harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp
>> (original)
>> +++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp
>> Mon Jan 5 02:14:19 2009
>> @@ -1289,7 +1289,7 @@
>>
>> //resolve and init object class
>> Class* objClass = resolveClass(klass, cp_idx, false);
>> - initializeClass(objClass);
>> + //initializeClass(objClass);
>> assert(!objClass->is_primitive());
>>
>> void* res = NULL;
>>
>>
>>
>
>
>
> --
> Managed Runtime Technology Center, Intel
>
