Mark Hindess wrote: > In message <49bfd516.6030...@gmail.com>, Tim Ellison writes: >> Sian January wrote: >>> Thanks Regis - that fixes the issue for me on Windows XP. I'm happy >>> to check it in if another committer agrees. >> Since we see it is a test case failure, and the fix does not affect the >> implementation, I suggest that it waits until after the release is declared. > > Since we see it is a test case failure, and the fix does not affect the > implementation, I'd vote to fix it now. ;-)
Ok, that's fine by me (subject to a review of the test patch of course). > Junit stops a test method at the first failed assert so any failure > could be hiding other "real" bugs, so if a test fix doesn't affect the > implementation then I think I'd always be +1 for applying it as soon as > possible. The patch shows that the remainder of the tests are passing, so I think we are ok in the implementation. Regards, Tim
