I think only return tempPath is ok.

2009/3/23 Regis <[email protected]>

> Hi,
>
> I noticed some code in File.fixSlashes:
>
>        String tempPath = new String(newPath, 0, newLength);
>        // If it's the same keep it identical for SecurityManager purposes
>        if (!tempPath.equals(origPath)) {
>            return tempPath;
>        }
>        return origPath;
>
> It could be simplified in logic as
>
> return new String(newPath, 0, newLength);
>
> But comments said it's for security reason, I'm not familiar with security,
> are there any cases we must keep the same String reference?
>
> --
> Best Regards,
> Regis.
>

Reply via email to