In message <[email protected]>, Alexei Fedotov writes: > > Sean, thanks. > I think, this is a great step. BTW, I think it makes sense to separate > implementation independent tests (if any) into a separate bundle. > This may be a hard task though.
Indeed. I thought about this and did a few quick grep's of the tests to see how difficult it would be. Let's just say I think it is best if Sean doesn't get distracted by looking at this problem. ;-) My feeling was that the approach taken by some of the early patches on JIRA was reasonable. In essence: 1) the compile tests targets in the modules should be extended to create jar files in the classlib/deploy/build directory 2) the run-tests targets should be modified to run the tests using the jars as (boot)classpath entries rather than the directories we currently use The number of jar files associated with a module would depend on the current classification of tests which is based on the use of subdirectories. The next step might be to create a file in the hdk classlib/deploy/build/ ant/test.xml that by default runs just the api tests but with options to run all the tests that could be executed using for example: PATH=/test/jre/bin:$PATH ant -f $HDK/build/ant/test.xml (Somewhat like the ant file for compiling native code that I created[0]). Making this work for non-harmony JVMs would be a final big step. Regards, Mark. [0] http://svn.apache.org/viewvc?view=rev&revision=667003 > On Thu, Apr 9, 2009 at 12:25 PM, Sean Qiu <[email protected]> wrote: > > > I guess HDK could pick up it from classlib. > > So both of them could make use of it. > > > > What do you think about it? > > > > 2009/4/9 Mark Hindess <[email protected]>: > > > > > > In message <[email protected]= > >, > > Sean > > > Qiu writes: > > >> > > >> 2009/4/9 Alexey Varlamov <[email protected]>: > > >> > Thanks for doing this work Sean, it's a long-expected move I believe= > . > > >> > > > >> > > >> Yes, I'll do it by modules. > > >> > > >> > Just a minor suggestion: it seems "setting.properties" is in fact > > >> > "test.properties", let's name it accordingly? > > >> > > >> Sure, thanks for reminding. > > >> > > >> > Please go ahead with commit anyway. > > >> > > >> Great. :-) > > > > > > +1 > > > > > > You mention creating a new artifact to store the tests but I believe th= > e > > > intention has always been that the current hdk artifact should contain > > > the test jars. > > > > > > Regards, > > > Mark. > > > > > > > > > > > > > > > > > -- > > Best Regards > > Sean, Xiao Xia Qiu > > > > > > --=20 > With best regards / =D3 =CE=C1=C9=CC=D5=DE=DB=C9=CD=C9 =D0=CF=D6=C5=CC=C1= > =CE=C9=D1=CD=C9, > Alexei Fedotov / =E1=CC=C5=CB=D3=C5=CA =E6=C5=C4=CF=D4=CF=D7, > http://www.telecom-express.ru/ > http://people.apache.org/~aaf/ > http://harmony.apache.org/ > http://code.google.com/p/openmeetings/ > > --0016e6dd966f34f3eb04671b0f5a-- >
