Re: svn commit: r764270 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/URLClassLoader.java

[Nathan Beyer]

I will look at it but someone else can pick it up if needed.

Sent from my iPhone

On Apr 12, 2009, at 9:02 PM, Kevin Zhou <zhoukevi...@gmail.com> wrote:

Hi Nathan,
I found that you applied a patch to java.net.URLClassLoader.
This defect have been reported previously on HARMONY-6136 [1].
The current patch given by you triggers two test errors for
"test_findClassLjava_lang_String" and "test_findResource methods" of
URLClassLoaderTest, which throws a java.lang.StackOverflowError.

If the META-INF/INDEX.LIST file of a jar contains a link to the jar, it will

invoke a endless recursion.
I have attached a new patch on [1]. Would you please help to try it?

[1] https://issues.apache.org/jira/browse/HARMONY-6136
[2] Stack Trace:
java.lang.StackOverflowError
   at java.net.URL.fixURL(URL.java:464)
   at java.net.URL.set(URL.java:509)
   at java.net.URL.set(URL.java:924)
   at java.net.URLStreamHandler.setURL(URLStreamHandler.java:298)
   at java.net.URLStreamHandler.parseURL(URLStreamHandler.java:234)
   at

org.apache.harmony.luni.internal.net.www.protocol.file.Handler.parseURL (Handler.java:111)

   at java.net.URL.<init>(URL.java:338)
   at java.net.URL.<init>(URL.java:155)
   at

org. apache. harmony. luni.internal.net.www.protocol.jar.Handler.parseURL(Handler.java:86)

   at java.net.URL.<init>(URL.java:338)
   at java.net.URL.<init>(URL.java:155)
   at

java.net.URLClassLoader$IndexFile.readIndexFile(URLClassLoader.java: 137) at java.net.URLClassLoader $URLJarHandler.<init>(URLClassLoader.java:316) at java.net.URLClassLoader.createURLJarHandler(URLClassLoader.java:1043)

   at java.net.URLClassLoader.access$5(URLClassLoader.java:1022)
   at

java.net.URLClassLoader $URLJarHandler.getSubHandler(URLClassLoader.java:480)

   at

java.net.URLClassLoader $URLJarHandler.findResources(URLClassLoader.java:345)

   at

java.net.URLClassLoader $URLJarHandler.findResources(URLClassLoader.java:347)

   at

java.net.URLClassLoader $URLJarHandler.findResources(URLClassLoader.java:347)

......