I committed this change. the ICU library is now a fetched download. This may require a clean and fetch before building correctly.
-Nathant On Mon, Apr 27, 2009 at 10:55 AM, Tim Ellison <[email protected]> wrote: > Should be as simple as this: > > Index: make/depends.properties > =================================================================== > --- make/depends.properties (revision 768745) > +++ make/depends.properties (working copy) > @@ -145,3 +145,15 @@ > asm.jar=${asm.dir}/asm-3.1.jar > asm.url=http://download.forge.objectweb.org/asm/asm-3.1.jar > asm.md5=4fbe0fd975ecc71480846ce272b483b0 > + > +icu4j.ver=icu4j_4.0 > +icu4j.dir=${depends.jars}/${icu4j.ver} > +icu4j.jar=${icu4j.dir}/icu4j-4_0.jar > +icu4j.url=http://download.icu-project.org/files/icu4j/4.0/icu4j-4_0.jar > +icu4j.md5=08397653119558593204474fd5a9a7e3 > + > +icu4j-charsets.ver=icu4j_4.0 > +icu4j-charsets.dir=${depends.jars}/${icu4j.ver} > +icu4j-charsets.jar=${icu4j.dir}/icu4j-charsets-4_0.jar > +icu4j-charsets.url=http://download.icu-project.org/files/icu4j/4.0/icu4j-charsets-4_0.jar > +icu4j-charsets.md5=5dd1d6aaffa6762e09541b3bb412d8ee > Index: make/depends.xml > =================================================================== > --- make/depends.xml (revision 768745) > +++ make/depends.xml (working copy) > @@ -57,6 +57,8 @@ > <check-one-file src="${dejavu-fonts.url}" > dest="${dejavu-fonts.zip}" /> > <check-one-file src="${derby.url}" dest="${derby.jar}" /> > <check-one-file src="${asm.url}" dest="${asm.jar}" /> > + <check-one-file src="${icu4j.url}" dest="${icu4j.jar}" /> > + <check-one-file src="${icu4j-charsets.url}" > dest="${icu4j-charsets.jar}" /> > </target> > > <target name="-check-win" if="is.windows" > depends="-really-check-win" /> > @@ -225,6 +227,15 @@ > <mkdir dir="${asm.dir}" /> > <download-one-file src="${asm.url}" dest="${asm.jar}" > md5="${asm.md5}" /> > + > + <mkdir dir="${icu4j.dir}" /> > + <download-one-file src="${icu4j.url}" > + dest="${icu4j.jar}" > + md5="${icu4j.md5}" /> > + <download-one-file src="${icu4j-charsets.url}" > + dest="${icu4j-charsets.jar}" > + md5="${icu4j-charsets.md5}" /> > + > </target> > > <target name="-download-win" if="is.windows"> > > > Tim Ellison wrote: >> Nathan Beyer wrote: >>> Why do we commit icu to svn? The jars are available via http, correct? >> >> Yes they are - I don't know why they are stored. We could (should) >> download them. >> >> Regards, >> Tim >> >>> On Apr 27, 2009, at 3:41 AM, Regis <[email protected]> wrote: >>> >>>> Tim Ellison wrote: >>>>> In the context of HARMONY-879, Nathan wrote: >>>>>> Can you verify that you're not still using ICU 3.8? I know >>>>>> I had to clean it out in a few places. >>>>> What do you mean? that simply updating my working copy doesn't do the >>>>> right thing? I seemed to be getting 4.0 behaviour in the tests. >>>>> ...and yet I do still see that I have a copy of ICU4J 3.8 in my >>>>> workspace since it has not been removed from the repository yet [1] >>>>> Can we delete all the 3.8 stuff now? >>>>> [1] >>>>> https://svn.apache.org/repos/asf/harmony/enhanced/classlib/trunk/depends/jars >>>>> >>>>> Regards, >>>>> Tim >>>> Oops, the icu4j_3.8 folder is empty, I'll remove it soon. The all jars >>>> of icu 3.8 have been removed, so I think it shouldn't affect any tests. >>>> >>>> -- >>>> Best Regards, >>>> Regis. >> >
