Hi Mark - I have uploaded a new patch regarding this issue on https://issues.apache.org/jira/browse/HARMONY-6507. Could you please take a look at it?
Thanks, Lang On Sat, May 29, 2010 at 2:49 AM, Lang Yang <yangl...@gmail.com> wrote: > Thanks Mark. > > I have created a patch under HARMONY-6507 (imageio_build.xml) for this. > Could you please take a look at this? > > Because I only need to use plugin classes from > package org.apache.harmony.x.imageio/plugins.* in order to perform the test, > so I have added a section under target "-compile-tests" to create a > supporting JAR file which contains all plugin classes, and added that JAR > file to the classpath of "test-module". It seems fixed the original problem > I had. > > I don't know if you prefer to use separate folders, or this way is just > fine? > > Thanks, > > Lang > > > On Sun, May 23, 2010 at 4:06 AM, Mark Hindess <mark.hind...@googlemail.com > > wrote: > >> >> In message <aanlktimsldy9qnl0pn9ia3ljv9j5zjxgqotxw9q7-...@mail.gmail.com >> >, >> Lang Yang writes: >> > >> > Thanks Alexey and Nathan! >> > >> > On Sat, May 22, 2010 at 4:09 PM, Nathan Beyer <ndbe...@apache.org> >> wrote: >> > >> > > It's not quite as simple as that. There are plenty of cases where >> > > using implementation specific classes is fine - most of the modules >> > > have hundreds of tests like this. This is why many of the modules have >> > > a 'api' and a 'impl' folder separation. >> > > >> > >> > Is that mean If I have used implementation specific classes, I should >> > put the test case in 'impl' folder? Is there an ANT target defined to >> > test them seperate? >> >> Adding a folder for implementation specific tests will require changing >> the modules/imageio/build.xml and modules/imageio/make/run-test.xml and >> changing the src/test directory structure. I can do this when the code >> freeze is over. >> >> -Mark. >> >> >> >
