Forwarding here to discuss on the list as something of a point of order on process for us to discuss. These are all open questions in my mind:
* is it ok for people to comment on pull requests? (or rather: to have a discussion there) * should people be reminded to please re-post their comment on the JIRA issue? * should we drop a link to the JIRA issue on such pull requests to redirect the conversation? Amr's comment was highly pertinent as the issue raised was regarding multiple p4ignore files but the patch only addressed one so letting it go unanswered or left on the pull request without reflecting it in JIRA seems bad. Now of course he re-posted his comment on JIRA but for the sake of this discussion if he had not, I'm wondering how best to handle this. Have other ASF projects reached opinions on this matter? Cheers, Schubert ---------- Forwarded message ---------- From: Amr El-Helw (JIRA) <[email protected]> Date: Mon, Sep 21, 2015 at 1:08 PM Subject: [jira] [Commented] (HAWQ-1) Remove .p4ignore files from source tree To: [email protected] [ https://issues.apache.org/jira/browse/HAWQ-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901301#comment-14901301 ] Amr El-Helw commented on HAWQ-1: -------------------------------- The pull request above only deletes one .p4ignore file. I have seen more than one such file in the source tree. (P.S. I already posted a comment in the pull request itself. Only posting here since I'm not sure which is the proper channel to comment on changes). > Remove .p4ignore files from source tree > --------------------------------------- > > Key: HAWQ-1 > URL: https://issues.apache.org/jira/browse/HAWQ-1 > Project: Apache HAWQ > Issue Type: Bug > Environment: N/A > Reporter: Gavin Sherry > Priority: Minor > > I notice that there are .p4ignore files in the source tree. These are irrelevant since HAWQ is hosted in git. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
