Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/138#discussion_r45961973
--- Diff: src/backend/utils/misc/etc/template-hawq-site.xml ---
@@ -20,131 +20,133 @@ under the License.
-->
<configuration>
- <property>
- <name>hawq_master_address_host</name>
- <value>%master.host%</value>
- </property>
-
- <property>
- <name>hawq_master_address_port</name>
- <value>%master.port%</value>
- </property>
-
- <property>
- <name>hawq_standby_address_host</name>
- <value>%standby.host%</value>
- </property>
-
- <property>
- <name>hawq_segment_address_port</name>
- <value>%segment.port%</value>
- </property>
-
- <property>
- <name>hawq_dfs_url</name>
- <value>%namenode.host%:%namenode.port%/%hawq.file.space%</value>
- </property>
-
- <property>
- <name>hawq_master_directory</name>
- <value>%master.directory%</value>
- </property>
-
- <property>
- <name>hawq_segment_directory</name>
- <value>%segment.directory%</value>
- </property>
-
- <property>
- <name>hawq_master_temp_directory</name>
- <value>%master.temp.directory%</value>
- </property>
-
- <property>
- <name>hawq_segment_temp_directory</name>
- <value>%segment.temp.directory%</value>
- </property>
+ <property>
+ <name>hawq_master_address_host</name>
+ <value>%master.host%</value>
+ <description>The host name of hawq master.</description>
+ </property>
+
+ <property>
+ <name>hawq_master_address_port</name>
+ <value>%master.port%</value>
+ <description>The port of hawq master.</description>
+ </property>
+
+ <property>
+ <name>hawq_standby_address_host</name>
+ <value>%standby.host%</value>
+ <description>The host name of hawq standby master.</description>
+ </property>
+
+ <property>
+ <name>hawq_segment_address_port</name>
+ <value>%segment.port%</value>
+ <description>The port of hawq segment.</description>
+ </property>
+
+ <property>
+ <name>hawq_dfs_url</name>
+ <value>%namenode.host%:%namenode.port%/%hawq.file.space%</value>
+ <description>URL for accessing HDFS.</description>
+ </property>
+
+ <property>
+ <name>hawq_master_directory</name>
+ <value>%master.directory%</value>
+ <description>The directory of hawq master.</description>
+ </property>
+
+ <property>
+ <name>hawq_segment_directory</name>
+ <value>%segment.directory%</value>
+ <description>The directory of hawq segment.</description>
+ </property>
+
+ <property>
+ <name>hawq_master_temp_directory</name>
+ <value>%master.temp.directory%</value>
+ <description>The temporary directory reserved for hawq
master.</description>
+ </property>
+
+ <property>
+ <name>hawq_segment_temp_directory</name>
+ <value>%segment.temp.directory%</value>
+ <description>The temporary directory reserved for hawq
segment.</description>
+ </property>
- <!-- HAWQ resource manager parameters -->
- <property>
- <name>hawq_rm_yarn_address</name>
- <value>%master.host%:9980</value>
--- End diff --
The port number better to be consist between hawq-site.xml,
template-hawq-site.xml and yarn-client.xml.
8032 <--> 9080
8030 <--> 9081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
