Github user xinzweb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/269#discussion_r49811471
--- Diff: tools/bin/generate-greenplum-path.sh ---
@@ -56,26 +56,26 @@ if [ -h \${GPHOME}/../hawq ]; then
fi
EOF
-# OSX does not need JAVA_HOME
+# OSX does NOT have DYLD_LIBRARY_PATH, add it
if [ "${PLAT}" = "Darwin" ] ; then
-cat << EOF
-PATH=\$GPHOME/bin:\$GPHOME/ext/python/bin:\$PATH
-DYLD_LIBRARY_PATH=\$GPHOME/lib:\$GPHOME/ext/python/lib:\$DYLD_LIBRARY_PATH
+ cat << EOF
--- End diff --
Good catch, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
