Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/279#discussion_r50430125
--- Diff: src/backend/access/external/pxfutils.c ---
@@ -47,6 +52,24 @@ void port_to_str(char **port, int new_port)
}
/*
+ * get_hdfs_location_from_filespace
+ *
+ * Get hdfs location from pg_filespace_entry
+ * The returned path needs to be pfreed by the caller.
+ */
+void get_hdfs_location_from_filespace(char** path)
+{
+ Assert(NULL != path);
--- End diff --
This code gets the file space of the current DB (MyDatabaseId), so even if
a specific table is configured to a different file space it shouldn't affect it.
Do you think it would be safer to get the file space of DB 'template1'
instead of the current session's DB? I followed the examples in other places in
the code to get the file space, and they either use the current table's DB or
MyDatabaseId.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
