Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/290#discussion_r50758859
  
    --- Diff: pxf/build.gradle ---
    @@ -122,6 +124,42 @@ subprojects { subProject ->
     }
     
     project('pxf-service') {
    +
    +
    +    task generateSources {
    --- End diff --
    
    can you please add a comment in the code explaining the basic idea here? If 
I understand correctly, we replace any mention of @pxfProtocolVersion@ with the 
value from gradle.properties?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to