Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51835736
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/PxfUnit.java ---
@@ -0,0 +1,672 @@
+package org.apache.hawq.pxf.plugins.json;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.BufferedReader;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.lang.reflect.Constructor;
+import java.security.InvalidParameterException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hawq.pxf.api.Fragment;
+import org.apache.hawq.pxf.api.Fragmenter;
+import org.apache.hawq.pxf.api.OneField;
+import org.apache.hawq.pxf.api.OneRow;
+import org.apache.hawq.pxf.api.ReadAccessor;
+import org.apache.hawq.pxf.api.ReadResolver;
+import org.apache.hawq.pxf.api.WriteAccessor;
+import org.apache.hawq.pxf.api.WriteResolver;
+import org.apache.hawq.pxf.api.io.DataType;
+import org.apache.hawq.pxf.api.utilities.InputData;
+import org.apache.hawq.pxf.service.FragmentsResponse;
+import org.apache.hawq.pxf.service.FragmentsResponseFormatter;
+import org.apache.hawq.pxf.service.utilities.ProtocolData;
+import org.codehaus.jackson.JsonFactory;
+import org.codehaus.jackson.JsonNode;
+import org.codehaus.jackson.JsonParseException;
+import org.codehaus.jackson.map.JsonMappingException;
+import org.codehaus.jackson.map.ObjectMapper;
+import org.junit.Assert;
+
+/**
+ * This abstract class contains a number of helpful utilities in
developing a PXF extension for HAWQ. Extend this class
+ * and use the various <code>assert</code> methods to check given input
against known output.
+ */
+public abstract class PxfUnit {
+
+ private static final Log LOG = LogFactory.getLog(PxfUnit.class);
+
+ private static JsonFactory factory = new JsonFactory();
+ private static ObjectMapper mapper = new ObjectMapper(factory);
+
+ protected static List<InputData> inputs = null;
+
+ /**
+ * Uses the given input directory to run through the PXF unit testing
framework. Uses the lines in the file for
+ * output testing.
+ *
+ * @param input
+ * Input records
+ * @param expectedOutput
+ * File containing output to check
+ * @throws Exception
+ */
+ public void assertOutput(Path input, Path expectedOutput) throws
Exception {
+
+ BufferedReader rdr = new BufferedReader(new
InputStreamReader(FileSystem.get(new Configuration()).open(
+ expectedOutput)));
+
+ List<String> outputLines = new ArrayList<String>();
+
+ String line;
+ while ((line = rdr.readLine()) != null) {
+ outputLines.add(line);
+ }
+
+ assertOutput(input, outputLines);
+
+ rdr.close();
+ }
+
+ /**
+ * Uses the given input directory to run through the PXF unit testing
framework. Uses the lines in the given
+ * parameter for output testing.
+ *
+ * @param input
+ * Input records
+ * @param expectedOutput
+ * File containing output to check
+ * @throws Exception
+ */
+ public void assertOutput(Path input, List<String> expectedOutput)
throws Exception {
+
+ setup(input);
+ List<String> actualOutput = new ArrayList<String>();
+ for (InputData data : inputs) {
+ ReadAccessor accessor = getReadAccessor(data);
+ ReadResolver resolver = getReadResolver(data);
+
+ actualOutput.addAll(getAllOutput(accessor, resolver));
+ }
+
+ Assert.assertFalse("Output did not match expected output",
compareOutput(expectedOutput, actualOutput));
+ }
+
+ /**
+ * Uses the given input directory to run through the PXF unit testing
framework. Uses the lines in the given
+ * parameter for output testing.<br>
+ * <br>
+ * Ignores order of records.
+ *
+ * @param input
+ * Input records
+ * @param expectedOutput
+ * File containing output to check
+ * @throws Exception
+ */
+ public void assertUnorderedOutput(Path input, Path expectedOutput)
throws Exception {
+ BufferedReader rdr = new BufferedReader(new
InputStreamReader(FileSystem.get(new Configuration()).open(
+ expectedOutput)));
+
+ List<String> outputLines = new ArrayList<String>();
+
+ String line;
+ while ((line = rdr.readLine()) != null) {
+ outputLines.add(line);
+ }
+
+ assertUnorderedOutput(input, outputLines);
+ }
--- End diff --
rdr.close()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
