When doing 'hawq init', we will check the segments number and dynamic to
decide some property values, for example 'default_segment_num',
'hawq_rm_nvseg_perquery_perseg_limit'. These properties will be write back
to hawq-site.xml by 'hawq config' command.
Another situation you mentioned is when we doing remove standby master
node, we will remove standby master item from hawq-site.xml.
And anytime you run 'hawq config' to re-define the GUC values,
hawq-site.xml is changed. This command might be used frequently.
Thanks.
Regards,
Radar
On Thu, Feb 25, 2016 at 2:15 PM, Konstantin Boudnik <c...@apache.org> wrote:
> Thanks for the explanation, Radar. But I am talking about hawq-site.xml,
> which
> is being re-written and the original content is copied under
> hawq-site.xml.org
> I guess I pointed to a wrong function, as I see that _write_config() is
> doing
> exactly what you said.
>
> Generating of the new files might be fine as we can make hawq user to own
> the
> configuration directory. But whatever config files are there and belong to
> root, should remain this way, in my option. Looking through the rest of the
> script, I see that there's a number of attempts to remove properties from
> the
> hawq-site file. E.g.
>
> remove_property_xml("hawq_standby_address_host", "%s/etc/hawq-site.xml"
> % self.GPHOME)
>
> which would be the subject of the issue we're discussing
>
> Cos
>
> On Thu, Feb 25, 2016 at 01:46PM, Radar Da lei wrote:
> > Hi Konstantin,
> >
> > Do you mean the step we read properties in hawq-site.xml, and then
> re-write
> > them to the file '_mgmt_config' ?
> >
> > This is to read some parameters easier when doing hawq init. The file
> will
> > be generate during each 'hawq init', then it's useless.
> >
> > In the plan, it will be generated into '/tmp' directory instead of hawq
> etc
> > directory, and be removed after hawq init finished.
> >
> > Thanks.
> >
> > Regards,
> > Radar
> >
> > On Thu, Feb 25, 2016 at 1:14 PM, Konstantin Boudnik <c...@apache.org>
> wrote:
> >
> > > Guys,
> > >
> > > I've been slowly working my way towards running the hawq out of the
> package
> > > (BIGTOP-2320) and have stepped on something that I can not quite
> explain.
> > >
> > > During the initial cluster init, there's an attempt to rewrite the
> > > configuration file hawq-site.xml Because of the standard location of
> the
> > > configs on linux (under /etc/<appname> directory) and default
> permissions
> > > (root:root), rewriting of the configs like that is problematic and
> > > insecure at
> > > least.
> > >
> > > Hence the question: why configuration file has to be rewritten given
> that
> > > it
> > > is already provided? Shall the logic be changed to not overriding an
> > > existing
> > > hawq-site?
> > >
> > > Regards,
> > > Cos
> > >
>
