we are working on some other items. it will be added soon... git submodule is like a link for external repo (it has been mentioned in another mail sent by Roman before). similar method is used for orca et al. If you have better method, let's discuss.
Cheers Lei On Wed, Jun 22, 2016 at 1:58 AM, Ting(Goden) Yao <[email protected]> wrote: > There has been new JIRA and PR filed against this issue: > https://issues.apache.org/jira/browse/HAWQ-849 > PR: https://github.com/apache/incubator-hawq/pull/737 > > PR comments: "...as we discuss in the mail list, we use an alternative > method to support reading orc files from HDFS which does not modify the > original orc repo. We could use a git submodule in the future...." > > I only see the PR removing the original commit, can someone elaborated on > "alternative method" here? Also, I don't think we discussed git submodule > on the mailing list. > -Goden > > On Mon, Jun 20, 2016 at 5:59 PM Lei Chang <[email protected]> wrote: > > > sounds great! +1 > > > > Cheers > > Lei > > > > On Tue, Jun 21, 2016 at 8:16 AM, Roman Shaposhnik <[email protected]> > > wrote: > > > > > On Fri, Jun 17, 2016 at 9:50 PM, Lei Chang <[email protected]> > wrote: > > > > My understanding of the intention here is not to maintain our own > copy > > > and > > > > and the target is to contribute it back to ORC project. It is just > for > > > > improving developer efficiency that might be introduced by delay from > > > > acceptance from another project. > > > > > > > > Hong and I had a offline discussion, I think we can have a better way > > for > > > > this. From initial development, we even do not need to change the > > library > > > > and if changes are needed, the proposal is to start JIRAs and submit > > pull > > > > requests on Apache ORC. > > > > > > That actually would be an ideal choice. Another choice, of course, > would > > > be to work with ORC community to enable plug-points that would then > > > enable you to replace/augment parts of ORC library functionality with > > > your own code (C++ OOP is supposed to be good for that ;-)). > > > > > > Finally, if all else fails you can always maintain a copy of the > > > library in a branch > > > waiting for all your required changes to find their way into the ORC > > > release > > > propper. > > > > > > And speaking of branches: at the end of the day our #1 priority should > > > be unblocking the upcoming HAWQ release. While we can keep the > > conversation > > > going on what to do with the ORC, we need to get a release branch > without > > > that commit out so that we can have a release done. > > > > > > Makes sense? > > > > > > Thanks, > > > Roman. > > > > > >
