Good improvement. +1.
Regards, Ivan On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <[email protected]> wrote: > LGTM. +1. > > On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <[email protected]> wrote: > > > I'd mask the output files after running feature tests in .gitignore and > > clean it up after running "make clean" or "make distclean". Anyone has > any > > suggestions? Thanks. > > > > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore > > index a2e6bd4..c7332b2 100644 > > --- a/src/test/feature/.gitignore > > +++ b/src/test/feature/.gitignore > > @@ -1 +1,2 @@ > > doc/ > > +**/*.out > > > > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile > > index adc6acc..e0985d1 100644 > > --- a/src/test/feature/Makefile > > +++ b/src/test/feature/Makefile > > @@ -35,6 +35,7 @@ doc: > > doxygen doxygen_template > > > > clean distclean: sharelibclean > > + find . -type f -name "*.out" |xargs rm -f > > $(RM) feature-test > > $(RM) feature-test.dSYM > > >
