+1 on some scan check. We can fix this as the first step. Thanks Lili
2016-09-05 21:51 GMT+08:00 Ming Li <[email protected]>: > Good suggestion. > > However, IMHO, we may need to firstly enable coverity scan check or clang > analysis scan. Also we should make the output of these check on a public > server so that all contributor can access them. > > On Mon, Sep 5, 2016 at 6:05 PM, Paul Guo <[email protected]> wrote: > > > -Werror > > Make all warnings into errors. > > I've seen many cases (not just hawq) before that ignoring gcc warning > leads > > to bugs. I'm wondering we should add the option for the gcc case. Given > > there may be a lot of warnings when building the common postgres code in > > hawq, we could at least enforce it in our own code at first > > (src/backend/cdb, src/backend/resourcemanager, src/test/feature, other > > directories?)? Any suggestion? > > >
