-Werror is an option used to make sure that compiling warnings are potentially bugs or errors. However, there is some trade-off between the usage of C code(from standard's view) and the specific implementation of gcc.
In my opinion, C grammer is not that complex so we'd better to open this option. You should try to open the flag and see what is going on. Just do it. Best Hong 2016-09-05 18:05 GMT+08:00 Paul Guo <[email protected]>: > -Werror > Make all warnings into errors. > I've seen many cases (not just hawq) before that ignoring gcc warning leads > to bugs. I'm wondering we should add the option for the gcc case. Given > there may be a lot of warnings when building the common postgres code in > hawq, we could at least enforce it in our own code at first > (src/backend/cdb, src/backend/resourcemanager, src/test/feature, other > directories?)? Any suggestion? >
