@ming, there is a discussion on this mailing list before about what should be included in the commit message.
Appending "close #" makes the commit message very messy. So the conclusion at that time is to not append "close #" to a commit message. If someone forgets closing a pull request, looks better to add a reminder to the pull request. Cheers Lei On Thu, Sep 8, 2016 at 11:42 AM, Ming Li <[email protected]> wrote: > Hi all committers, > > It seems that we can not close other's pull request conviently ( > https://issues.apache.org/jira/browse/INFRA-12580), it is better to tell > git hook automatically close PR automatically. > > Here is the steps I added into the wiki( > https://cwiki.apache.org/confluence/display/HAWQ/Contributing+to+HAWQ): > # In case of some contributor often forget to close pull request, > # Append commit message to automatically close pull request after code > merged. e.g. PR number is 12: > run `git commit --amend` and append "(close #12)" to commit message. >
