Michael, thanks for creating the Jiras. Two things need to happen before it can be considered for a formal review/merge. 1. Create a pull request against https://github.com/apache/incubator-hawq 2. Remove references to name of author in the code and comments which are not in english. 3. Design/usage doc for each of the connectors attached in the respective jiras. This doc should explain how to use the plugin along with very clear examples.
The PXF Json connector went through this process prior to code review/merge. You can refer to https://issues.apache.org/jira/browse/HAWQ-178. Following that the pull request was created here https://github.com/apache/incubator-hawq/pull/302 On Mon, Oct 17, 2016 at 1:58 AM, Michael Pearce <michael.pea...@ig.com> wrote: > Thanks Goden. > > Ive created this morning the two Jira Tickets. > > JDBC > https://issues.apache.org/jira/browse/HAWQ-1108 > > SOLR > https://issues.apache.org/jira/browse/HAWQ-1109 > > Devin ive cc’d you into the JIRA’s I hope you see this mail. > > Thanks > Mike > > > From: Goden Yao <goden...@apache.org> > Date: Friday, October 14, 2016 at 5:47 PM > To: "dev@hawq.incubator.apache.org" <dev@hawq.incubator.apache.org>, > Michael Pearce <michael.pea...@ig.com> > Subject: Re: JDBC/SOLR PXF Plugin > > Yes this is merged and I've closed this JIRA. > That JIRA doesn't include jdbc plugin you wanted, so I'd suggest you file > a separate one and cc Devin if you think his implementation is better. > > We can start from there and drive the work to completeness. > -Goden > On Fri, Oct 14, 2016 at 1:20 AM Michael Pearce <michael.pea...@ig.com > <mailto:michael.pea...@ig.com>> wrote: > Hi All, > > > > I noticed this JIRA the github PR looks to be merged is this correct? Can > this ticket be closed? Or is there critical outstanding work? > > https://issues.apache.org/jira/browse/HAWQ-779 > > > > In the ticket Devin Jia mentions he wants to also merge in his > contributions for PXF-Solr and PXF-Jdbc which the above was the foundation > stones needed for them. > > > > The JDBC one being a much improved version of > https://github.com/kojec/pxf-field/tree/master/jdbc-pxf-ext > > > > Did the tickets/jira stories ever get raised to add these extra pxf > plugins (I cant find them yet its mentioned to raise them in the above > mentioned Jira) > > > > I think both these plugins would be beneficial for the community, very > much so the JDBC one ;) > > > > Can we look to merge his work in? What do we need to do still? > > > > Cheers > > Mike > > > > > > The information contained in this email is strictly confidential and for > the use of the addressee only, unless otherwise indicated. If you are not > the intended recipient, please do not read, copy, use or disclose to others > this message or any attachment. Please also notify the sender by replying > to this email or by telephone (+44(020 7896 0011) and then delete the email > and any copies of it. Opinions, conclusion (etc) that do not relate to the > official business of this company shall be understood as neither given nor > endorsed by it. IG is a trading name of IG Markets Limited (a company > registered in England and Wales, company number 04008957) and IG Index > Limited (a company registered in England and Wales, company number > 01190902). Registered address at Cannon Bridge House, 25 Dowgate Hill, > London EC4R 2YA. Both IG Markets Limited (register number 195355) and IG > Index Limited (register number 114059) are authorised and regulated by the > Financial Conduct Authority. > -- shivram mani
