Agree with Hong that it is a good practice to add clarification for the revert.
The message for the revert regarding dockerfile has been updated to below: *Revert "HAWQ-1248. Merge Dockerfiles for HAWQ Dev into HAWQ code base."* *This reverts commit 440ce59.* *Reason for revert: RAT check fail with unapproved license in some of the files added* Best regards, Ruilong Huo On Sat, Jan 14, 2017 at 5:26 AM, Hong <[email protected]> wrote: > I noticed that there is a reverted commit > <https://github.com/apache/incubator-hawq/commit/ > 37d5c28c44fde95987cb9fc96318e3b8fe78f04c> > for this. I just want to know what's the problem, thanks! Also, I suggest > next time if we do revert some previous commits, please modify the commit > log info adding some explanations. > > Take these commits for example: > Tensorflow#181fa201560e147b5152ccb9ad86d86aa4e05972 > <https://github.com/tensorflow/tensorflow/commit/ > 181fa201560e147b5152ccb9ad86d86aa4e05972> > Spark#cd662bc7a2050264f40650442858a85c4827b608 > <https://github.com/apache/spark/commit/cd662bc7a2050264f40650442858a8 > 5c4827b608> > > Thanks, > Hong > > 2016-12-28 0:55 GMT-05:00 Richard Guo <[email protected]>: > > > Hi everyone, > > > > HAWQ team is building HAWQ dev docker images. The purpose is to provide > an > > out-of-box way for developers to setup build and test environment for > HAWQ. > > > > A demo could be found on github hawq-docker > > <https://github.com/guofengrichard/hawq-docker> . Currently only CentOS > 7 > > is supported. CentOS 6 will be supported soon. It is based on Zhanwei's > > work. > > > > The idea is to predefine all the environment setup steps in the > dockerfile > > and then build the image from dockerfile with tools provided by docker. > > After that, users can simply create containers with the docker image and > > then do the HAWQ build and test jobs. > > Also a Makefile is provided to simplify this process. Please refer to the > > README in the github repository for more details. > > > > Regarding the place to host the docker images and dockerfiles, does > anyone > > have any idea? Comments and discussions are welcomed. > > > > Best Regards, > > Richard > > >
