The try/catches are staying in to add the HFile.toString() to the exception, so the user will have some indication of which file threw the exception.
On Sat, May 22, 2010 at 10:39 PM, <st...@duboce.net> wrote: > > >> On 2010-05-22 22:38:21, stack wrote: >> > > > This patch is radical. Its going to throw up some new stuff. Best to get it > in now. I had two minor issues. I can fix on commit. > > > - stack > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/75/#review38 > ----------------------------------------------------------- > > > On 2010-05-21 15:23:07, Todd Lipcon wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://review.hbase.org/r/75/ >> ----------------------------------------------------------- >> >> (Updated 2010-05-21 15:23:07) >> >> >> Review request for hbase and Ryan Rawson. >> >> >> Summary >> ------- >> >> In particular fixes issues where a compaction that got an error on one >> storefile would happily proceed and just remove all that data. Or a user >> scan would just show empty results instead of an error. >> >> >> This addresses bug HBASE-2519. >> http://issues.apache.org/jira/browse/HBASE-2519 >> >> >> Diffs >> ----- >> >> src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java 70b85af >> src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 3433811 >> src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 038a335 >> src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java >> 70f42dc >> src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScanner.java >> 657018f >> >> src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java >> 4b16540 >> src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 6c3153b >> src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java >> 52d228b >> src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java >> fde872c >> src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 238e804 >> src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 55a926f >> >> src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java >> PRE-CREATION >> src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java >> 228ab2c >> >> src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueScanFixture.java >> e1ffcc3 >> src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java >> 6ed0209 >> src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java >> fd77329 >> >> Diff: http://review.hbase.org/r/75/diff >> >> >> Testing >> ------- >> >> new unit tests >> >> >> Thanks, >> >> Todd >> >> > >
