----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/79/#review47 -----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java <http://review.hbase.org/r/79/#comment232> should probably use the accessor here. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java <http://review.hbase.org/r/79/#comment233> do we get any meaningful sleep here? I have not really seen Thread.yield in a long time - Ryan On 2010-05-23 19:49:26, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/79/ > ----------------------------------------------------------- > > (Updated 2010-05-23 19:49:26) > > > Review request for hbase and Ryan Rawson. > > > Summary > ------- > > Test wasn't waiting until the put thread had started before it started > reading, so would often fail having read 0 columns. > > > This addresses bug HBASE-2589. > http://issues.apache.org/jira/browse/HBASE-2589 > > > Diffs > ----- > > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 44e7e6d > > Diff: http://review.hbase.org/r/79/diff > > > Testing > ------- > > Ran it a few times on my box locally, seems to pass now where it used to fail > most of the time. > > > Thanks, > > Todd > >
