----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/84/#review54 -----------------------------------------------------------
Looks pretty good. The one thing I don't like is that checkAndMutate takes a Writable, and then downcasts based on instanceof. Can we extract a common interface between Put and Delete? maybe something like RowMutation or RowOperation, which would have getRowLock and a "performMutation()" or something? What do you guys think? trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/84/#comment308> typo: executed trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.hbase.org/r/84/#comment309> since this modifies its parameter, I don't know that it makes sense to also return it. I'd make this void and add javadoc that it will mutate its arg (also explain what it does) - Todd On 2010-05-25 12:22:03, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/84/ > ----------------------------------------------------------- > > (Updated 2010-05-25 12:22:03) > > > Review request for hbase. > > > Summary > ------- > > Submitting to RB on behalf of Michael Dalton > > > This addresses bug HBASE-2579. > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java 946565 > trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java > 946565 > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java > 946565 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > 946565 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 946565 > trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java > 946565 > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > 946565 > > Diff: http://review.hbase.org/r/84/diff > > > Testing > ------- > > > Thanks, > > Todd > >
