----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/88/#review75 -----------------------------------------------------------
Ship it! +1 lets do it - Ryan On 2010-05-25 16:04:24, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/88/ > ----------------------------------------------------------- > > (Updated 2010-05-25 16:04:24) > > > Review request for hbase. > > > Summary > ------- > > Version of hbase-2599 for 0.20 branch for 0.20.5. > > It cuts DNS lookups from HServerInfo and uses the regionservers name > everywhere instead of ip sometimes and a lookedup hostname at other times. > Also puts hostname:port into .META. rather than IP. Removing DNS lookups > makes it so there is no possibility for disagreement over hostname if master > gets one answer for an IP and the regionserver has another. > > Other notes: > > It replaces variable servername with hostnameandport so its clear whats going > on. > > Does some cleanup in HServerInfo renaming data member 'name' as 'hostname' > and then purges DNS caching and lookups from this class. It removes some > unnecessary setters and does some javadoc fix ups. > > Removes the dumb serverAddressToServerInfo from ServerManager. > > > This addresses bug hbase-2599. > > > Diffs > ----- > > branches/0.20/src/java/org/apache/hadoop/hbase/ClusterStatus.java 948218 > branches/0.20/src/java/org/apache/hadoop/hbase/HServerInfo.java 948218 > branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java > 948218 > branches/0.20/src/java/org/apache/hadoop/hbase/master/HMaster.java 948218 > > branches/0.20/src/java/org/apache/hadoop/hbase/master/ProcessRegionOpen.java > 948218 > branches/0.20/src/java/org/apache/hadoop/hbase/master/ServerManager.java > 948218 > > branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 948218 > branches/0.20/src/test/org/apache/hadoop/hbase/TestServerInfo.java > PRE-CREATION > branches/0.20/src/webapps/master/table.jsp 948218 > > Diff: http://review.hbase.org/r/88/diff > > > Testing > ------- > > Doing now. > > > Thanks, > > stack > >
