> On 2010-05-26 13:06:23, Todd Lipcon wrote: > > unit test?
I'll write a test, but it won't be "unit" at all ;) - Jean-Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/89/#review78 ----------------------------------------------------------- On 2010-05-25 17:14:31, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/89/ > ----------------------------------------------------------- > > (Updated 2010-05-25 17:14:31) > > > Review request for hbase. > > > Summary > ------- > > Patch that removes all the MSG_CALL_SERVER_STARTUP related code that was > screwing us more than helping us. Now, when a region server pings back with a > different start code, we just shut it down. > > > This addresses bug HBASE-2613. > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/HMsg.java 948234 > /trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 948234 > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 948234 > > Diff: http://review.hbase.org/r/89/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
