----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/112/#review119 -----------------------------------------------------------
Ship it! Looks good to me. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java <http://review.hbase.org/r/112/#comment671> You don't unregister.. I don't think it matters... src/test/java/org/apache/hadoop/hbase/master/TestMaster.java <http://review.hbase.org/r/112/#comment672> That would be an improvement. You'd get the 'table region closest' even though the entry didn't have a server address yet. - stack On 2010-06-01 18:43:36, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/112/ > ----------------------------------------------------------- > > (Updated 2010-06-01 18:43:36) > > > Review request for hbase and Jonathan Gray. > > > Summary > ------- > > Patch fixes the issue and includes a unit test. Note that there is a TODO in > the unit test - would appreciate comments on what the right behavior is there. > > > This addresses bug HBASE-2560. > http://issues.apache.org/jira/browse/HBASE-2560 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/master/HMaster.java c713245 > src/test/java/org/apache/hadoop/hbase/master/TestMaster.java PRE-CREATION > > Diff: http://review.hbase.org/r/112/diff > > > Testing > ------- > > > Thanks, > > Todd > >
