> On 2010-06-02 17:24:34, Todd Lipcon wrote: > > this seems like a reasonable framework, but I'd rather see this stay around > > as a branch until there is at least one or two actual things using it for a > > real purpose. Otherwise I think we'll end up shipping an API that we later > > realize doesn't work for real apps. What do you think?
This seems like a good idea when dev'ing an Interface. After the 3rd implemenation you'll have some confidence in your Interface. - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/96/#review121 ----------------------------------------------------------- On 2010-05-31 22:47:25, Andrew Purtell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/96/ > ----------------------------------------------------------- > > (Updated 2010-05-31 22:47:25) > > > Review request for hbase. > > > Summary > ------- > > This patch is the parts of the HBASE-2001 patch which implements support for > the RegionObserver interface. This enables extension of the regionserver > through stacking dynamically loaded classes i.e. from jars on HDFS onto > upcalls from HRegion. I made some improvements over the other patch and added > a test case. There are other parts of 2001 which need some thought and some > work and would not be useful without client side support. This is the part > which could be immediately useful. > > Submitted for feedback. > > Incorporates a user suggestion and Stack +1 about hooking compaction. > > > This addresses bug HBASE-2001. > http://issues.apache.org/jira/browse/HBASE-2001 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 2413e98 > > src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java > 71f738e > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 515b42f > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassloading.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java > PRE-CREATION > > Diff: http://review.hbase.org/r/96/diff > > > Testing > ------- > > All the new unit tests plus TestHRegion pass locally. > > > Thanks, > > Andrew > >
